Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTH command to smtp service #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fvdveen
Copy link

@fvdveen fvdveen commented Jul 13, 2018

Added the AUTH command with the options PLAIN, LOGIN and CRAM-MD5 to the
smtp service.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sammynx
Copy link
Collaborator

sammynx commented Jul 16, 2018

If I run telnet 127.0.0.1 <configured-port> there is no welcome message and after EHLO command the connection is closed.

@sammynx
Copy link
Collaborator

sammynx commented Jul 16, 2018

Also could you put a configuration sample in smtp.go. See services/ldap/ldap.go for an example.

@sammynx
Copy link
Collaborator

sammynx commented Jul 16, 2018

In smtp_test.go func TestMain() could you cleanup the storage when testing is done.

and do a rebase on master. thnx

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@99dcbf3). Click here to learn what that means.
The diff coverage is 53.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #386   +/-   ##
=========================================
  Coverage          ?   41.76%           
=========================================
  Files             ?       78           
  Lines             ?     8930           
  Branches          ?        0           
=========================================
  Hits              ?     3730           
  Misses            ?     4757           
  Partials          ?      443
Impacted Files Coverage Δ
services/smtp/server.go 86.66% <ø> (ø)
services/smtp/smtp.go 83.07% <100%> (ø)
services/smtp/conn.go 50.71% <51.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99dcbf3...f976349. Read the comment docs.

@nl5887
Copy link
Contributor

nl5887 commented Nov 7, 2018

I think it is not that interesting to check for a pre-existing list of users and secrets, but more what users and secrets are being used.

Added the AUTH command with the options PLAIN, LOGIN and CRAM-MD5 to the
smtp service.
@Neustradamus
Copy link

Please do not add unsecure and old CRAM-MD5, LOGIN mechanisms.

LOGIN has been replaced by PLAIN but PLAIN can not be used without a secure connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants