Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #371

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CapacitorSet
Copy link
Contributor

This is a copy of #316, for which I had accidentally not used a feature branch.

@codecov-io
Copy link

codecov-io commented Jul 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@674ac4f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #371   +/-   ##
=========================================
  Coverage          ?   43.58%           
=========================================
  Files             ?       71           
  Lines             ?     8333           
  Branches          ?        0           
=========================================
  Hits              ?     3632           
  Misses            ?     4285           
  Partials          ?      416
Impacted Files Coverage Δ
server/honeytrap.go 3.26% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674ac4f...84c3e19. Read the comment docs.

@martijnjanssen
Copy link
Contributor

There is also a bunch of commented lines in the services.go. I'm pretty sure that can also go, it was added in the initial commit, but it's never used again.

@CapacitorSet
Copy link
Contributor Author

Indeed, I noticed that, but I think it's groundwork for future developments. Pinging @nl5887 for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants