[WIP] services: mongodb: add mongodb service #357
Conversation
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=========================================
Coverage ? 41.61%
=========================================
Files ? 78
Lines ? 8810
Branches ? 0
=========================================
Hits ? 3666
Misses ? 4719
Partials ? 425
Continue to review full report at Codecov.
|
|
|
||
| answer := s.MongoDBHandler(port, b) | ||
|
|
||
| s.ch.Send(event.New( |
There was a problem hiding this comment.
Could you extract specific data in connection request, like username, password, application etc.
| [service.mongodb] | ||
| type="mongodb" | ||
| version="2.5.1" | ||
| dbs=[ {Name="My_DB", SizeOnDisk="8192", Empty="false"}, |
There was a problem hiding this comment.
allowed usernames and passwords?
|
When testing this I get: |
|
--ssl is not implemented yet. |
IllIlIlIlI
changed the title
IllIlIlIlI
changed the title
services/mongodb/encode.go
Outdated
| fn, ok := mapCommands[md.cmd] | ||
|
|
||
| if !ok { | ||
| log.Error("Error: command not implemented: %s", md.cmd) |
There was a problem hiding this comment.
It would be good to make an event here with the non existing command.
services/mongodb/mongodb_handler.go
Outdated
| md.port = strconv.Itoa(port) | ||
|
|
||
| // ev := make(map[string]interface{}) | ||
| ev := make(eventLog) // what's the difference? |
There was a problem hiding this comment.
difference is that ev is of type eventLog now, otherwise it would be of type map[string]interface{}
This are two different types allthough they do the same.
services/mongodb/mongodb.go
Outdated
| defer conn.Close() | ||
|
|
||
| br := bufio.NewReader(conn) | ||
| port := conn.RemoteAddr().(*net.TCPAddr).Port |
There was a problem hiding this comment.
You could put port in mongodbService then it does not have to be passed around as function argument.
|
Hi this would be a nice addition to have. Is there anything we can do to get this request merged ? |
No description provided.