Use commentDepth options in Follow Comments keyboard navigation #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please remove the language additions to all languages except for en.json. As the build process replicates to all others. I'm also not sure what this is trying to solve/fix - can you detail what this change is some more please? |
@BenMcGarry done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: N/A
Tested in browser: Chrome
commentDepthoptions only supported when navigating to comments link by clicking on it. This PR supports commentDepth options when navigating to comments using keyboard shortcut as well (if defined under Browsing > Keyboard Navigation > Follow Comments)