New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent neverEndingComments from loading duplicate comments #5425

Open

guanzo wants to merge 2 commits into honestbleeps:master from guanzo:master

guanzo commented Nov 12, 2022 •

edited

Relevant issue: https://www.reddit.com/r/Enhancement/comments/l1boqd/comments_duplicating_in_never_ending_reddit/
Tested in browser: chrome, firefox

To reproduce:

scroll to bottom of page, wait for /api/morechildren request to send
scroll up until the red loading... text exits the bottom of the viewport
scroll back down. A 2nd /api/morechildren request should be sent, causing duplicate comments.

Solution is to ensure that the same loader link is never clicked twice.

My implementation checks if the loader link has the loading text, if so then ignore it.

It works, but will there be any issues with translations? Like will the loading text check fail for spanish users, etc?

guanzo added 2 commits

November 12, 2022 14:02


          prevent neverEndingComments from loading duplicate comments

37cf5a2


          fix flow check

bc6d46d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment