Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebDAV support to backups #5398

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ElijahPepe
Copy link
Contributor

@ElijahPepe ElijahPepe commented May 1, 2022

Relevant issue: #5273
Tested in browser: Firefox 90.0.1/99.0.1

@BenMcGarry
Copy link
Collaborator

BenMcGarry commented May 2, 2022

Thanks for the PR!

We are having some discussions on this among the team due to the concern of storing plaintext WebDAV credentials in file store in RES. Please stand by.

@ElijahPepe
Copy link
Contributor Author

Passwords for accounts are stored in plaintext.

@BenMcGarry
Copy link
Collaborator

Reddit account passwords are a lot less risk compared to someones file storage.

@ElijahPepe
Copy link
Contributor Author

ElijahPepe commented May 2, 2022

Very fair argument. Storing passwords in localStorage or the web SQL database API is obviously not feasible; any in-browser solutions are crackable.

The two ideas I have are to leave it as it is with a strong warning, or use OAuth and have the WebDAV connection work in the backend. There is a credential management API that could theoretically work, but it would require a lot more work than the other two solutions.

@BenMcGarry
Copy link
Collaborator

Yeah I think having a strong warning might be the approach we want to go with. We have it in our privacy policy that we do store in plain text (https://redditenhancementsuite.com/privacy). But for this make it explicitly clear to say "Hey, these are the risks. Proceed with caution". Looking to see if we have a way we can flag a popup on user select to act as the warning.

@ElijahPepe
Copy link
Contributor Author

Looking to see if we have a way we can flag a popup on user select to act as the warning.

I added a commit to trigger a window.alert() using onChange(). Hopefully that works.

Copy link

@ShadowJonathan ShadowJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants