Replace momentjs with (much leaner) dayjs #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't personally vouch for it but have read about ⏰ Day.js 2KB immutable date library alternative to Moment.js with the same modern API https://github.com/iamkun/dayjs reference: moment/moment#2373 (comment) |
larsjohnsen
force-pushed
the
moment-locale-lean
branch
from
d63914f
to
6f2edfa
Compare
larsjohnsen
changed the title
|
Thanks for the suggestion, @xxyuk. That seems to fit our use case well! |
kevinji
reviewed
Feb 18, 2019
lib/utils/localization.js
Outdated
| const dayjs = require('dayjs'); // eslint-disable-line global-require | ||
| dayjs.extend(require('dayjs/plugin/relativeTime')); // eslint-disable-line global-require | ||
| dayjs.extend(require('dayjs/plugin/localizedFormat')); // eslint-disable-line global-require | ||
| dayjs.locale(locale()); |
There was a problem hiding this comment.
Hmm, since we can get the locale via locale, maybe we can replace all of the require lines with a single require(`dayjs/locale/${locale()}`); call?
There was a problem hiding this comment.
I don't think Webpack will be able to resolve that without also bundling all locales.
Dayjs is extensible. By being selective methods and locales are imported, we get a dependency that less than 20 kB (in contrast to momentjs' 300 kB)
larsjohnsen
force-pushed
the
moment-locale-lean
branch
from
6f2edfa
to
3410c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dayjs is modular and extendable. By being selective with what methods and locales are imported, we get a dependency that is less than 20 kB (in contrast to momentjs' 300 kB)
Tested in browser: Chrome 73