Skip to content

Commit

Permalink
Firefox Mobile needs min 120 due to API support (#5498)
Browse files Browse the repository at this point in the history
* Firefox Mobile needs min 120 due to API support

* lint

* Update beta manifest
  • Loading branch information
benmcgarry committed Mar 10, 2024
1 parent 41273bb commit c201755
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion build.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const targets = {
firefox: {
browserName: 'firefox',
browserMinVersion: '115.0',
browserMobileMinVersion: '120.0',
manifest: './firefox/manifest.json',
noSourcemap: true,
},
Expand Down Expand Up @@ -73,7 +74,7 @@ const homepageURL /*: string */ = packageInfo.homepage;
// production builds uses version number to keep the build reproducible
const buildToken = isProduction ? version : devBuildToken;

async function buildForBrowser(targetName, { manifest, noSourceMap, browserName, browserMinVersion }) {
async function buildForBrowser(targetName, { manifest, noSourceMap, browserName, browserMinVersion, browserMobileMinVersion }) {
const context = {
entryPoints: {
'foreground.entry': './lib/foreground.entry.js',
Expand Down Expand Up @@ -154,6 +155,7 @@ async function buildForBrowser(targetName, { manifest, noSourceMap, browserName,
__homepage__: homepageURL,
__author__: author,
__browser_min_version__: browserMinVersion,
__browser_mobile_min_version__: browserMobileMinVersion,
}
Object.keys(replace).forEach(v => {
text = text.replaceAll(v, replace[v]);
Expand Down
2 changes: 1 addition & 1 deletion firefox/beta/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"strict_min_version": "__browser_min_version__"
},
"gecko_android": {
"strict_min_version": "__browser_min_version__"
"strict_min_version": "__browser_mobile_min_version__"
}
},
"icons": {
Expand Down
2 changes: 1 addition & 1 deletion firefox/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"strict_min_version": "__browser_min_version__"
},
"gecko_android": {
"strict_min_version": "__browser_min_version__"
"strict_min_version": "__browser_mobile_min_version__"
}
},
"icons": {
Expand Down

0 comments on commit c201755

Please sign in to comment.