Code cleanup and improved typings #3072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
commented
Jan 23, 2022
Pull Request Test Coverage Report for Build 4645292148
💛 - Coveralls |
Supereg
reviewed
May 6, 2022
| @@ -120,7 +126,7 @@ export interface StaticPlatformPlugin extends PlatformPlugin { | |||
| * | |||
| * @param {(foundAccessories: AccessoryPlugin[]) => void} callback | |||
| */ | |||
| accessories(callback: (foundAccessories: AccessoryPlugin[]) => void): void; | |||
| accessories(callback: (foundAccessories: Array<AccessoryPlugin & AccessoryConfig>) => void): void; | |||
There was a problem hiding this comment.
I think this typing doesn't really represent reality (and might even break current implementations?).
The weird thing is, that we really only require the name: string property (and optionally check for the uuid_base?: string property). Using AccessoryConfig though will add the accessory: AccessoryName | AccessoryIdentifier requirement and the optional _bridge?: BridgeConfiguration property which both are never used.
| // @ts-ignore | ||
| const uuidBase: string | undefined = accessoryInstance.uuid_base; // optional base uuid | ||
|
|
||
| log.info("Initializing platform accessory '%s'...", accessoryName); |
There was a problem hiding this comment.
Please don't remove this log statement.
ghost
suggested changes
Sep 15, 2022
| @@ -120,7 +126,7 @@ export interface StaticPlatformPlugin extends PlatformPlugin { | |||
| * | |||
| * @param {(foundAccessories: AccessoryPlugin[]) => void} callback | |||
| */ | |||
| accessories(callback: (foundAccessories: AccessoryPlugin[]) => void): void; | |||
Co-authored-by: Andi <mail@anderl-bauer.de>
|
Hi all, just popping into get a status update on this! @ericanderson and @Supereg any status update on this:? cc @donavanbecker for context Cheers, Ben! |
|
@ericanderson, please reopen direct towards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code cleanup.