Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end encrypted notifications #1679

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

End-to-end encrypted notifications #1679

wants to merge 1 commit into from

Conversation

zacwest
Copy link
Member

@zacwest zacwest commented Jun 21, 2021 •
edited

Fixes #70. Requires home-assistant/core#52048.

  • Pass cleartext commands through, need to wire up the command manager to the register calls. Also still need to make the fcm repo handle them, or make core send them through the legacy path.
  • Avoid erroring the update registration webhook, which doesn't like extra params and so the push_config is going to start erroring for.
  • Tests.
  • Get dependent core PR merged.

Summary

Allows decrypting notifications in the service extension.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

This relies on changes in core, specifically my branch of @robbiet480's branch which encrypts using the same webhook secret that we already decrypt webhook contents for.

Since we were denied the com.apple.developer.usernotifications.filtering entitlement, we need to do the cleartext commands passthrough for things like clear_notification.

zacwest
zacwest commented Jun 21, 2021
View reviewed changes
Sources/Shared/API/HAAPI.swift
[
"platform": Current.device.systemName(),
"push_token": pushID,
"push_url": "http://localhost:5000/home-assistant-mobile-apps/us-central1/encryptedV1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo

@zacwest zacwest changed the title Support end-to-end encrypted push notifications End-to-end encrypted push notifications Jun 21, 2021
@zacwest zacwest changed the title End-to-end encrypted push notifications End-to-end encrypted notifications Jun 21, 2021
@zacwest zacwest marked this pull request as draft September 26, 2021 03:47
@EkilDeew
Copy link

Any ideas why this never went out of draft ?
I see the corresponding PR on core was stale as well.
What happened ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add push notification end to end encryption
3 participants
@zacwest @EkilDeew @homeassistant