Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page listing the active deprecations #922

Closed
wants to merge 2 commits into from

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 19, 2024

Experimenting with adding this page, as I've been working on HEP 2 and think that it'd help maintainers (users too in fact!) if such a page existed and was maintained over time.

image

For example, I bumped a couple of warnings in #921 and updated the page accordingly.

image

@maximlt maximlt requested a review from hoxbro March 19, 2024 02:49
@maximlt maximlt changed the base branch from main to bump_warnings March 19, 2024 02:50
@hoxbro
Copy link
Member

hoxbro commented Mar 19, 2024

Did you try putting this information in a table?

I don't think we should mention old deprecations. This should ideally be handled by versioning the documentation. As we don't have that, I think it is ok for now.

users too in fact!

TBH, I don't think users will look at a webpage to see deprecations, but I understand your point.

@maximlt
Copy link
Member Author

maximlt commented Mar 19, 2024

Did you try putting this information in a table?

Done in 07597fa

image

I don't think we should mention old deprecations. This should ideally be handled by versioning the documentation. As we don't have that, I think it is ok for now.

I should have explained why I included the deprecation history. It's almost the most important piece of information I need as a maintainer as I want an easy way to know for how long a feature has been deprecated. I had to do so much Github digging when releasing Param 2.0 through the release notes and Github issues/PRs.
In my mind, when a feature is eventually removed from the code base, it is to be removed from this page.

TBH, I don't think users will look at a webpage to see deprecations, but I understand your point.

Just sharing these links I just found (the page I added in this PR is nowhere near these!):

@hoxbro
Copy link
Member

hoxbro commented Mar 19, 2024

I think there is two conflicting perspective with your last comment, one is what is good for the developer, the second is what is good for the user. I don't see them as the same thing.

I should have explained why I included the deprecation history. It's almost the most important piece of information I need as a maintainer as I want an easy way to know for how long a feature has been deprecated. I had to do so much Github digging when releasing Param 2.0 through the release notes and Github issues/PRs.

This is looking from it as a developer. From a users perspective he doesn't care for previous versions deprecations, he care about his version.

Just sharing these links I just found (the page I added in this PR is nowhere near these!):

May I ask you when did you last look at this? Because I haven't looked at them before, and I would say I use pytest a lot. 🙃

@maximlt
Copy link
Member Author

maximlt commented Mar 19, 2024

My main motivation for this PR was to experiment with how to help maintainers better handle deprecations over time, to serve the development of HEP 2. I picked Param because I know more about it's deprecation warnings than any other library, and because it has many active ones so it's a good use case.

I thought that having that as a listing in the docs could also be useful for users. The review shows that this view isn't shared. I think this discussion should take place in HEP 2 with a larger group, so I'm going to close this PR, I can still point to it from HEP 2 as a possible way to improve things.

@maximlt maximlt closed this Mar 19, 2024
@philippjfr
Copy link
Member

Personally I call out deprecations explicitly in the release notes but do potentially see value in an overview and/or migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants