Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite panel/models/reactive_html.ts #6527

Merged
merged 1 commit into from May 6, 2024

Conversation

mattpap
Copy link
Collaborator

@mattpap mattpap commented Mar 19, 2024

This PR fixes lint errors and replaces all instances of any type in panel/models/reactive_html.ts and related modules.

@mattpap mattpap added this to the v1.5.0 milestone Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (6e3da22) to head (6f59502).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6527      +/-   ##
==========================================
+ Coverage   82.79%   82.81%   +0.02%     
==========================================
  Files         313      313              
  Lines       46168    46168              
==========================================
+ Hits        38224    38235      +11     
+ Misses       7944     7933      -11     
Flag Coverage Δ
ui-tests 39.98% <ø> (+<0.01%) ⬆️
unitexamples-tests 71.10% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattpap mattpap force-pushed the mattpap/panel.models.reactive_html branch from c5f123c to d4cb91e Compare March 21, 2024 12:34
@mattpap mattpap force-pushed the mattpap/panel.models.reactive_html branch from d4cb91e to 6f59502 Compare April 4, 2024 13:15
@philippjfr philippjfr merged commit d63824f into main May 6, 2024
15 checks passed
@philippjfr philippjfr deleted the mattpap/panel.models.reactive_html branch May 6, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants