Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom nav bar with more dropdown menus #396

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 21, 2024

@droumis I had a quick look and I think in the end it's not too hard to customize the nav bar to have multiple dropdowns.

image

This PR is not meant to be merged, I think you could use these changes as a basis for your changes to the nav bar (half the relative links in this PR are fake 馃檭 ).

I just found the nav bar template for the version we use in this repo (found in the lock file) on the theme's github https://github.com/pydata/pydata-sphinx-theme/blob/v0.13.3/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-nav.html. Saved that in a new file. I inspected the HTML of the nav bar on the currently deployed website, copied and adapted it to add more dropdowns and external links. We'll probably have to update the template when bumping the version of the theme, it shouldn't be too hard though.


I added a Websites dropdown with links to the HoloViz websites. That's because I've been wondering how to better expose HoloViz and its projects on all the websites. Perhaps that dropdown should be added to all the websites? Just a thought!


Since we were wondering, in the newer versions of the theme it's possible to customize the text of the More dropdown with the header_dropdown_text option (pydata/pydata-sphinx-theme#1423). Useful, but not enough for us I think.

@maximlt maximlt marked this pull request as draft March 21, 2024 21:04
@droumis
Copy link
Member

droumis commented Mar 22, 2024

Nice! thanks. I'll work on the changes to the HoloViz site as we discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants