New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HEP] HEP Purpose, Policy, and Guidelines #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
The document says a HEP proposes a major change to the HoloViz ecosystem
. I think that's a bit of a strong statement. For example, I don't consider HEP 1 has brought any major changes, and I don't think HEP 2 I'm working on is going to change HoloViz significantly. The scope of NEPs for example is a bit more laxed with a NEP being a design document providing information to the NumPy community, or describing a new feature for NumPy or its processes or environment
. I'd suggest widening the scope of HEPs to something similar to NEPs.
Other than that, it looks good to me.
I've adjusted the language to broaden the scope, please check if this is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks!
updated to align with proposed format |
Thanks! I think ultimately it'd be good to have the HEPs be visible directly on the website (like others do with NEPs, PEPs, etc.). Looking at the now formatted HEP, it has no title which won't help creating a web page out of it (I think the page title for all HEPs would be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've made a series of changes you can consider that treats "enhancement" as being either a change or a formalization/codification of existing practice to improve clarity or streamline processes. Accordingly, numerous instances of the word "change" were replaced with "enhancement" or one of the two specific alternatives.
If people find this approach awkward, I'm perfectly ok with a section at the front that says that in this document a "change" could either be an actual change in policy or practice, or simply a change in how well something has been documented or formalized. But if you do that, using "change" as the universal term for an HEP, then I'd argue that it should be "HCP", i.e., that all of them are change requests. So I'm honoring the "E" in "HEP" by treating all of them as "enhancements", only some of which are actual changes. Someone else can decide if they agree with that approach!
Co-authored-by: James A. Bednar <jbednar@continuum.io>
I updated the HEPs and the template to include a title. I would prefer to leave those rows in the table. |
Ok, fine by me! |
Looks mostly good; couple comments: Is HEP1 missing: Can we also put Lastly, how do we ensure that HoloViz maintainers have seen this? When I joined, I wasn't aware of HEPs. |
Currently, the resolution section is only recommended, not required. For HEP 1, I personally think the link to the GitHub PR in the table provides sufficient context for the community discussion that took place, which wasn't too much. But I've gone ahead and added a Resolution section under the summary for HEP 1.
Maybe we can link to this HEP 0 from the governance documents. All HoloViz maintainers should read the governance to which they are bound, so it seems like a good place to make any new-comers aware of HEPs. But I think this is beyond discussion of HEP 0. |
I'm leaning towards it should be required, or at least a I imagine in the future there could be 100 HEPs; someone will not be able to read all that and their discussions. so, having a section that clearly outlines what each HEP is putting forward or whats required of maintainers would make things a whole lot more manageable.
:) No one really told me anything about the governance docs either... |
I wrote https://holoviz.org/contributing.html#operating-guide for HoloViz maintainers, I think it could be updated to introduce HEPs and point to HEPs relevant to maintainers. |
OK, I'll make the |
I will be updating #388 in light of the proposed changes here. I think it'll help us gauge whether authoring a HEP hard following the format isn't too hard (I hope not! It shouldn't be, otherwise people will take other approaches). |
thanks for the input, team. merging now |
This PR introduces HEP 0, which outlines the purpose, policy, and guidelines for future HEPs within the HoloViz ecosystem. This document aims to clarify the process of proposing, discussing, and implementing enhancements for HoloViz evolution.
I've also updated HEP 1 to align with the format proposed by HEP 0.