Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding clean-notebooks pre-commit #357

Merged
merged 12 commits into from Mar 13, 2023
Merged

Adding clean-notebooks pre-commit #357

merged 12 commits into from Mar 13, 2023

Conversation

droumis
Copy link
Member

@droumis droumis commented Mar 13, 2023 •
edited

Thanks to @hoxbro for the assist

@droumis
Copy link
Member Author

droumis commented Mar 13, 2023

the test looks good.

  • First, I ran the CI knowing that there was something to clean and the docs build correctly failed
  • Then I ran pre-commit locally on all files and pushed the changes
  • The CI dev build was then successful

@droumis droumis marked this pull request as ready for review March 13, 2023 12:12
@droumis droumis requested a review from hoxbro March 13, 2023 12:21
hoxbro
hoxbro reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nit changes.

examples/tutorial/index.ipynb Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.github/workflows/docs.yaml Show resolved Hide resolved
droumis and others added 3 commits March 13, 2023 14:38
@droumis @hoxbro
add newline
3c1cb52 
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@droumis @hoxbro
stop doc build if pre-commit fails
fc6279d 
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@droumis @hoxbro
remove empty attachments key
229ffe3 
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
hoxbro
hoxbro reviewed Mar 13, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@droumis droumis merged commit 4b7b9e2 into main Mar 13, 2023
@droumis droumis deleted the clean-nbs-precommit branch March 13, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxbro hoxbro hoxbro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@droumis @hoxbro