-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump flake and fix wasm builds; CI improvements #108
Conversation
with a recent rust update (to 1.75.0) this breaks wasm builds as they wrongly inherit the flags defined in CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUSTFLAGS. as it's unclear to me why that is, i opted to clear the entire environment which also disables inheritance, and add only the desired necessary variables back
@steveej It looks fine to me but the tests are failing. |
yes it's not fine yet. the workaround clears the env of something that's apparently needed. i couldn't figure out yet what needs to be removed from the env and stop inheritance for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup
@jost-s i figured out the env var that needs to be cleared. if you approve i'll clean up the commit history before merging. |
@steveej Wait, this seems like a problem with the |
I'll merge this as a workaround to unblock the release. |
the inner for that target, the the effect of it is the environment variable that i removed from the inner job in this PR, because we don't intend that effect for the wasm target. let me know if that explains it for you. |
@steveej In effect does that mean that mold cannot link wasm targets? And why is that outer env var's target x86_64 even applied for wasm32? |
true.
because of this, specifically the bold part
within that context, the environment variable |
@steveej But the target platforms are different, it's x86_64 in one and wasm32 in the other. Why a specific target triple if it's applied in a general way? Is the x86_64 applied anyway despite the difference in platform? |
does that help? |
please see commit messages for details