Change project directory environment variable #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `$ZSH` for the project root directory conflicts with zsh projects and plugins (e.g., oh-my-zsh). Change `$ZSH` -> `$DOTFILES`. WIP: #8/b
|
This has come up a few times in the past; previously I've sided along the lines of being -1 because I didn't want to cause a lot of conflicts for existing users. Willing to reconsider, though; what are other people's thoughts on this? |
|
Based on the number of times this comes up, it seems worth it to rename. 😃 +1 from me. |
|
tag v2.0 for breaking backwards compatibility 👍 If this gets approved, then for anyone that relied on git grep 'ZSH' |
This was referenced Dec 12, 2016
|
Another vote as my personal fork has this implemented. |
ajdexter
pushed a commit
to ajdexter/dotfiles
that referenced
this pull request
Jan 5, 2019
moved conditional git configs to git/install.zsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$ZSHfor the project root directory conflicts with zsh projectsand plugins (e.g., oh-my-zsh). Change
$ZSH->$DOTFILES.WIP: defrank#8/b