Referral independent code flow #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
| @@ -248,10 +251,47 @@ const updateRewardsCheckRunner = () => { | |||
| }); | |||
| } | |||
|
|
|||
| const referralTradesRunner = () =>{ | |||
| cron.schedule('0 */4 * * *', async () => { | |||
There was a problem hiding this comment.
double check the frequency of running this. This should be executed when you run the plugin code initially
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
| } | ||
|
|
||
| if (feeUsdtValue < 1) { | ||
| throw new Error('Total unrealized earned fees are too small to be converted to realized earnings'); |
There was a problem hiding this comment.
This should be in the server error message
abeikverdi
reviewed
May 7, 2024
| {} | ||
| ); | ||
|
|
||
| throw new Error('Settlement is not available at the moment, please retry later'); |
There was a problem hiding this comment.
this should go to the server message errors
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
| - user | ||
| x-token-permissions: | ||
| - can_read | ||
| /user/referral/history: |
There was a problem hiding this comment.
we dont need this if its for the graph
abeikverdi
reviewed
May 7, 2024
| }); | ||
| }; | ||
|
|
||
| const fetchUserReferrals = (req, res) => { |
There was a problem hiding this comment.
remove if its for the graph
abeikverdi
reviewed
May 7, 2024
abeikverdi
reviewed
May 7, 2024
| return unrealizedRecords; | ||
| }; | ||
|
|
||
| const getRealizedReferral = async (opts = { |
There was a problem hiding this comment.
this should display bundled data
abeikverdi
reviewed
May 8, 2024
| !toolsLib.getKitConfig().referral_history_config.active | ||
| ) { | ||
| // TODO it should be added to the messages | ||
| throw new Error('Feature is not active'); |
There was a problem hiding this comment.
The message should be added to the server messages @fetok12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.