Extreme value search among one attribute and multiple nodes #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #124 +/- ##
==========================================
+ Coverage 64.49% 64.57% +0.08%
==========================================
Files 9 9
Lines 521 525 +4
==========================================
+ Hits 336 339 +3
- Misses 185 186 +1
Continue to review full report at Codecov.
|
YoungFaithful
requested changes
Nov 1, 2019
| # all attribute-node pairs in clust_data | ||
| data_types = [k for k in keys(clust_data.data)] | ||
| attribute_nodes = data_types[occursin.(data_type, data_types)] | ||
| if isempty(attribute_nodes) |
There was a problem hiding this comment.
Instead of leaving the if statement open, we could just return the error and end the if statement after line 99. What do you think?
| # this contains the special case that data_type is an attribute-node pair | ||
| else | ||
| data = zeros(clust_data.T*length(attribute_nodes), clust_data.K) | ||
| for i in 1:length(attribute_nodes) |
There was a problem hiding this comment.
Alternative could be:
for (i, attribute_node) in enumerate(attribute_nodes)
That can generally simplify the readability of the code as you can now use attribute_node instead of attribute_nodes[i]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define an extreme value based on an attribute (e.g.
wind) and it finds the corresponding extreme value among all nodes.Previously, only an attribute-node pair was allowed for extreme value identification (e.g.
wind-dena72).