Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added user selectable search domain and updated docker files #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkumeboshi
Copy link
Contributor

user can select the google search domain in setting.
The domain is checked against a configurable list of supported TLDs.

Updated all docker files to include all changes in config/settings

…ins list

updated docker files to support changes in config/settings
@juniorbotelho
Copy link
Contributor

Great changes! If the repository maintainer merges it, I'll update the docker image on Docker Hub with your customizations included.

@hnhx
Copy link
Owner

hnhx commented Feb 17, 2023

Whats the point of the user changing the domain?

The host will complete the request anyway, and the domain has nothing to do with language preferences.

@jkumeboshi
Copy link
Contributor Author

That's a good question.
Actually from my tests I saw that Google behavior changes slightly depending on various parameters:

  1. The web site domain
  2. The language you choose
  3. Your location (Actual or GeoIP)
  4. Additionaly there is the ability to filter results by language

That happens at least accessing Google normally using the browser.
for point 1, 2, and 4 we can allow the user to have his specific settings, to mimic his preferred Google expected behavior.

@hnhx
Copy link
Owner

hnhx commented Feb 17, 2023

I have done some tests and I couldn't find a difference in the results when I compared .hu and .com.
So I don't think this has any usecase.

@r1klz
Copy link

r1klz commented Feb 18, 2023

Maybe different TLDs don't have any effect; but, like on SearX, this option 4 would be interesting. 😺

@jkumeboshi
Copy link
Contributor Author

Maybe different TLDs don't have any effect; but, like on SearX, this option 4 would be interesting. 😺

@r1klz you mean the user may change result's language in the search results page?

Something similar to DDG that has quick settings for language, safe search and search dates too:
immagine

@r1klz
Copy link

r1klz commented Feb 22, 2023

Exactly, @jkumeboshi.
Sometimes I search websites/things in my native language and the results I need doesn't appear. So I think this option is very good to be implemented...
However, depending on the instance (the country where it's hosted), it will return some results based in that country. But if it does not have a instance in your country? Know what I mean?

@juniorbotelho
Copy link
Contributor

You need to solve branch conflicts!

@hnhx
Copy link
Owner

hnhx commented Feb 24, 2023

I will probably implement in the quick langauge change when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants