Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce explicit plugin versions #1170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tillerino
Copy link

Hi!

I recently bumped the Maven version in Nixpgks (NixOS/nixpkgs#238746) and ran into some small but annoying manual effort w.r.t. the digital package. The issue is that digital is packaged using the double invocation method which unfortunately breaks if not all maven plugin versions are set explicitly.

We're extending the documentation to prevent this (NixOS/nixpkgs#238774), but I'm reaching out to fix the packages which have already been packaged. In this PR, we explicitly set the versions of a few plugins which hadn't had their versions set explicitly before and add a check with the enforcer plugin to make sure this won't accidentally break in the future.

Note that the exact versions of the plugins that you're using are not important to us and please do change them as you see fit. We only ask that you explicitly set the versions of all plugins so that downstream upgrades can run automatically.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (220e551) 56.5% compared to head (4e0873a) 56.5%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1170   +/-   ##
========================================
  Coverage      56.5%   56.5%           
- Complexity     6578    6579    +1     
========================================
  Files           680     680           
  Lines         35562   35562           
  Branches       4800    4800           
========================================
+ Hits          20117   20119    +2     
+ Misses        14235   14234    -1     
+ Partials       1210    1209    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants