Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring set #1143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shahrajsingh
Copy link

refactored code to improve the readability of the code,

  • decomposed conditional in doLayoutNormal to new calculateMergerPositionY for improved readability
    the new method has been added at line 62.

  • Renamed variable width to maxWidth for better readability in the doLayoutNormal method
    this change has been added to line 78, and subsequent changes have been made to use the new change.

  • created a new method named containsNonVariableFragments(), which is called in doLayout() method at line 157 to improve code readability.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (aa9c142) 56.5% compared to head (9f646d5) 56.6%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1143   +/-   ##
========================================
  Coverage      56.5%   56.6%           
- Complexity     6571    6576    +5     
========================================
  Files           679     679           
  Lines         35494   35503    +9     
  Branches       4792    4792           
========================================
+ Hits          20082   20099   +17     
+ Misses        14202   14196    -6     
+ Partials       1210    1208    -2     
Impacted Files Coverage Δ
...nn/digital/builder/circuit/FragmentExpression.java 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants