Skip to content

Commit

Permalink
Merge pull request #355 from hmrc/PLATUI-2898-remove-unused-code
Browse files Browse the repository at this point in the history
PLATUI-2898 remove unused ActiveXObject code
  • Loading branch information
TimothyFothergill committed Mar 21, 2024
2 parents 2a44f01 + 3986a5b commit 285b3f3
Show file tree
Hide file tree
Showing 4 changed files with 130 additions and 105 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [6.9.0] - 2024-03-21

### Changed

- Removed unused ActiveXObject references in line with dropping IE support

## [6.8.0] - 2024-03-21

### Changed
Expand All @@ -21,7 +27,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Changed

- version number bumped to trigger release - no other changes
- Version number bumped to trigger release - no other changes

## [6.6.0] - 2024-03-19

Expand Down
219 changes: 121 additions & 98 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "hmrc-frontend",
"version": "6.8.0",
"version": "6.9.0",
"description": "Design patterns for HMRC frontends",
"scripts": {
"start": "gulp dev",
Expand Down
6 changes: 1 addition & 5 deletions src/components/timeout-dialog/utils.js
@@ -1,7 +1,3 @@
// TODO Remove the ActiveXObject code and test against Edge
// Decision agreed with DIAS to remove the timeout dialog functionality for IE)
/* global ActiveXObject */

const { warn } = console;

const utils = {
Expand Down Expand Up @@ -41,7 +37,7 @@ const utils = {
},

ajaxGet(url, success) {
const xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject('Microsoft.XMLHTTP');
const xhr = new XMLHttpRequest();
xhr.open('GET', url);
xhr.onreadystatechange = () => {
if (xhr.readyState > 3 && xhr.status === 200) success(xhr.responseText);
Expand Down

0 comments on commit 285b3f3

Please sign in to comment.