ECL-252: Fix accessibility report issues #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/uk/gov/hmrc/economiccrimelevyregistration/views/FirstContactNameView.scala.html
Outdated
Show resolved
Hide resolved
pangiole-hmrc
force-pushed
the
ECL-252
branch
2 times, most recently
from
3102859
to
984dd36
Compare
- move the `h1` (header) and `p` (paragraph) elements to the above
and outside of the form element
- add internationalized labels where missing
- remove empty select items
pangiole-hmrc
force-pushed
the
ECL-252
branch
from
984dd36
to
44f6a83
Compare
app/uk/gov/hmrc/economiccrimelevyregistration/models/AmlSupervisorType.scala
Outdated
Show resolved
Hide resolved
peter-hazell
changed the title
With the intent to pass the accessibility tests, we agreed upon adding the `label` element with the same text content as the heading. We are also styling it as hidden (so to put it out of sight) Resolves: ECL-252
pangiole-hmrc
force-pushed
the
ECL-252
branch
from
140d5e5
to
c5b1792
Compare
This commit attempts a workaround for the issue filed at hmrc/play-frontend-hmrc#223 Resolves: ECL-252
Closed
pangiole-hmrc
commented
Feb 21, 2023
| @@ -53,7 +53,7 @@ object AmlSupervisorType { | |||
| ): Seq[RadioItem] = { | |||
| val amlProfessionalBodySupervisorOptions: Seq[SelectItem] = | |||
| SelectItem( | |||
| text = "" | |||
| text = " " | |||
There was a problem hiding this comment.
peter-hazell
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all accessibility issues by:
h1(header) andp(paragraph) elements to the above and outside of the form elementNote: I couldn't reproduce the accessibility report on my local environment.
I'd need some help from @jamesvarghese701