Add yarn audit to build and nightly pipelines
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This change adds
yarn auditto both the build and nightly pipelines as part of the security check steps. Therefore the build will now break on PR build if any vulnerable tools are introduced / new vulnerabilities found.Note: The is an outstanding feature request for Yarn to be able to ignore false positives, but I think it's better to fail while there are no vulnerabilities than use
try {...} catch {...}by default (yarnpkg/yarn#6669)Does this PR introduce a breaking change?* (check one with "x")