Update conn.go to cover the STATUS_NO_MORE_FILES status response #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse status is not handled correctly The `accept` method STATUS_NO_MORE_FILES does not cover the case of STATUS_NO_MORE_FILES response status, which makes the code snippet (in souce code [line 1281 in client.go](https://github.com/hirochachacha/go-smb2/blob/c8e61c7a5fa7bcd1143359f071f9425a9f4dda3f/client.go#L1281C26-L1281C26)) could not handle the reponse as expected (as a STATUS_NO_MORE_FILES response).
leolovesmile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update conn.go to fix the problem that the STATUS_NO_MORE_FILES status is not handled correctly
The
acceptmethod does not cover the case of STATUS_NO_MORE_FILES response status, which makes the code snippet (in souce code line 1281 in client.go) could not handle the reponse as expected (as a STATUS_NO_MORE_FILES response).