Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish viewUid and trackUid with wheel events #904

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

keller-mark
Copy link
Member

Description

What was changed in this pull request?

This pull request adds the properties trackUid and viewUid to the object that is published on wheel events (that have been registered via .on('wheel', callback) using the JS API).

Why is it necessary?

Currently, wheel events only publish the track with which they are associated. However, this could be ambiguous if one wants to identify the track since there is no information about the parent view. To be more precise about which track a wheel event is associated with, we can also include the view UID in the event object.

Fixes #___

Checklist

  • Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
  • Unit tests added or updated
  • Documentation added or updated
  • Example(s) added or updated
  • Update schema.json if there are changes to the viewconf JSON structure format
  • Screenshot for visual changes (e.g. new tracks or UI changes)
  • Updated CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant