Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React18 #1104

Draft
wants to merge 4 commits into
base: pkerpedjiev/webpack5
Choose a base branch
from
Draft

Conversation

pkerpedjiev
Copy link
Member

@pkerpedjiev pkerpedjiev commented Jul 18, 2022

Description

What was changed in this pull request?

  • Update React to react 18
  • Change hglib.viewer() function to return a promise rather than an object. This is necessary because the React component render isn't necessarily synchronous and we may not have a reference to it immediately. We'll likely have to bump the major version number of the library.

Still have to:

  • Add an upgrade guide to the docs

Why is it necessary?

  • Getting with the times.

Fixes #___

Checklist

  • Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
  • Unit tests added or updated
  • Documentation added or updated
  • Example(s) added or updated
  • Update schema.json if there are changes to the viewconf JSON structure format
  • Screenshot for visual changes (e.g. new tracks or UI changes)
  • Updated CHANGELOG.md

@pkerpedjiev pkerpedjiev changed the base branch from develop to pkerpedjiev/webpack5 July 18, 2022 00:50
@pkerpedjiev pkerpedjiev mentioned this pull request Jul 20, 2022
7 tasks
@sehilyi
Copy link
Member

sehilyi commented Sep 27, 2022

Hi @pkerpedjiev, just checking in since I am excited about this PR. Do you plan to upgrade React version in the near future? I assume, due to the recent adoption of Vite, this will need to be revisited.

@pkerpedjiev
Copy link
Member Author

Yeah this PR will need to be rebased on the latest vite changes. I haven't had time to work on it recently but it's something we'll have to do at some point.

@sehilyi sehilyi mentioned this pull request Nov 17, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants