Click event

[pkerpedjiev]

Description

What was changed in this pull request?

• Updated the click event to return a list of objects for each track under the event
• I couldn't update the tests because they wouldn't run for some reason. See slack message here.
• Updated a couple d3 packages which remove the use of the global event and switched clientPoint to pointer. It does the same thing but its parameters are reversed and pointer is newer.

Why is it necessary?

• So that click events can cover combined tracks

Fixes #___

Checklist

• Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
• Unit tests added or updated
• Documentation added or updated
• [o] Example(s) added or updated
• [o] Update schema.json if there are changes to the viewconf JSON structure format
• [o] Screenshot for visual changes (e.g. new tracks or UI changes)
• Updated CHANGELOG.md

[alexander-veit]

I can't get this branch to work. The zooming seems broken. See https://gyazo.com/b0a561caa39223c9702a85dd61f0f965

Does it work for you? (The develop branch works for me)

[alexander-veit]

Also, I needed to fix these versions in order to get it to run. But I assume that is unrelated to the problem above.

"webpack": "4.30.0",
"webpack-cli": "3.3.0",
"webpack-dev-server": "3.2.0"

[pkerpedjiev]

Hey Alex, I've been slow on this but haven't forgotten. Will work on getting it fixed this week.

[alexander-veit]

Thanks a lot, Pete.

…

________________________________ From: Peter Kerpedjiev ***@***.***> Sent: Tuesday, June 28, 2022 10:43 PM To: higlass/higlass ***@***.***> Cc: Veit, Alexander ***@***.***>; Comment ***@***.***> Subject: Re: [higlass/higlass] Click event (PR #1098) Hey Alex, I've been slow on this but haven't forgotten. Will work on getting it fixed this week. — Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_higlass_higlass_pull_1098-23issuecomment-2D1169472753&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DZrjha5TxCMzdMNwkv9Sk0jaq15cPzdG8oIpMwBrEzg&m=hkAUsRqYP3uQgzasNtkf0knGNFKk7eJW_KjpeZbDTPNdSdm40TzRnqvz8nYZi0k_&s=BBBKQ6NNrzbeJCh_tA2jAMC9KinH-ArzR62z2cyyGPw&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM24ZBBMUTCQSP5D5UQC4R3VROZ3ZANCNFSM5X5S57CA&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=DZrjha5TxCMzdMNwkv9Sk0jaq15cPzdG8oIpMwBrEzg&m=hkAUsRqYP3uQgzasNtkf0knGNFKk7eJW_KjpeZbDTPNdSdm40TzRnqvz8nYZi0k_&s=gYIANVyQCWh-vxB4Zt-ezmPP2q0-fa4n6B3Q9cQT144&e=>. You are receiving this because you commented.Message ID: ***@***.***>

[pkerpedjiev]

Mind trying again? I stacked this on top of #1102 which should fix the zoom issues.

[alexander-veit]

Thanks, it works well now. I added the custom modal changes to this PR. Plugin tracks can now implement clickDialog() which returns a React component that will be displayed in a modal. If multiple overlaid tracks are clicked that all implement clickDialog(), the React components are stacked and displayed in the modal.