Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nan as zero #1057

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Nan as zero #1057

wants to merge 5 commits into from

Conversation

pkerpedjiev
Copy link
Member

Description

What was changed in this pull request?

  • Added an option that lets line tracks treat NaN values as zeros. This lets it render an unbroken line.

With the option on:

image

With the option off:

image

Why is it necessary?

Fixes #___

Checklist

  • Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
  • Unit tests added or updated
  • Documentation added or updated
  • Example(s) added or updated
  • Update schema.json if there are changes to the viewconf JSON structure format
  • Screenshot for visual changes (e.g. new tracks or UI changes)
  • Updated CHANGELOG.md

Copy link
Member

@flekschas flekschas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

There were 3 changes I couldn't interpret. Other the PR looks good 👍

CHANGELOG.md Show resolved Hide resolved
app/scripts/HorizontalLine1DPixiTrack.js Outdated Show resolved Hide resolved
app/scripts/Tiled1DPixiTrack.js Show resolved Hide resolved
app/scripts/TiledPixiTrack.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants