fix: Expand allowed characters in keys #4044 #4045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2024 20:28
joshgoebel
reviewed
Apr 30, 2024
joshgoebel
reviewed
May 1, 2024
src/languages/yaml.js
Outdated
Comment on lines
24
to
28
| { begin: /\w[\w :()\./\-*@]*:(?=[ \t]|$)/ }, | ||
| { // double quoted keys - with brackets | ||
| begin: /"\w[\w :()\./-]*":(?=[ \t]|$)/ }, | ||
| begin: /"\w[\w :()\./\-*@]*":(?=[ \t]|$)/ }, | ||
| { // single quoted keys - with brackets | ||
| begin: /'\w[\w :()\./-]*':(?=[ \t]|$)/ }, | ||
| begin: /'\w[\w :()\./\-*@]*':(?=[ \t]|$)/ }, |
There was a problem hiding this comment.
Awesome!
Can we please keep the - at the very end of the character group so we don't need the extra escape?
Also, could we get a test case added to the markup tests to show that this works as intended?
There was a problem hiding this comment.
@joshgoebel I moved the location of - and created a test file. When running the test, it looks like the picture below, is that right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This modification extends the definition of the key to include spaces, colon, slash, hyphen, and parentheses. It also changes the key to include more character types while maintaining the pattern that ends in colon.
Checklist
CHANGES.md