Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Aeson 2.x and LTS 19? #340

Open
nodew opened this issue Sep 19, 2022 · 5 comments
Open

Support Aeson 2.x and LTS 19? #340

nodew opened this issue Sep 19, 2022 · 5 comments

Comments

@nodew
Copy link

nodew commented Sep 19, 2022

From this PR #332, I see
LTS 19 unfortunately doesn't work, due to the Aeson 2.x versioning.
Could we upgrade Aeson to 2.x? Is there any hard dependency on Aeson 1.x?

@serras
Copy link
Collaborator

serras commented Sep 23, 2022

The problem is that some of the dependencies we use are not compatible with Aeson 1.x. But I can try again, maybe it works this time!

@sfwc
Copy link

sfwc commented Nov 9, 2022

Has there been any progress on this recently? I'd like to use mu-haskell in a new project, but not having LTS 19 is turning out to be a dealbreaker.

Taking a stab at it myself, the issues with Aeson 2 seem relatively easy to fix (just KeyMap for objects, plus passing the -json build flag to the graphql package), but next I see an issue in http2-client (maybe GHC version-related?) that I'm not immediately sure what to do about.

@serras
Copy link
Collaborator

serras commented Nov 10, 2022

Not really. The main problem is indeed http2-client, which no longer compiles. Not only that, the package http2 has added its own Client module which conflicts with that one :/

@listx
Copy link

listx commented Jan 24, 2023

The problem is that some of the dependencies we use are not compatible with Aeson 1.x. But I can try again, maybe it works this time!

I think you meant to say 2.x?

Anyway, is there some way others can help out here? Are we blocked by haskell-grpc-native/http2-client#79?

@serras
Copy link
Collaborator

serras commented Jan 24, 2023

@listx That's exactly the blocker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants