-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fill up the missing jsdoc for classes and series types #8307
Conversation
@TorsteinHonsi could you have a look? |
@oysteinmoseng could you have a review? It seems good. |
Thanks for the PR! Our main purpose of the JSDoc doclets is to generate our class reference and options reference. The existing doclets that show up in the class reference are carefully revised to be informative to our users. Unfortunately, the remaining code is not revised. So exposing those doclets results in some inconsistencies and errors in the generated documentation, plus there are internal functions that we don't want to document because they may change in the future etc. |
b38a0b0
to
25079f2
Compare
@TorsteinHonsi you are right. Then I make a plugin to filter out those accidentally exposed docs. could you have a review again? The extra docs must be filtered out now. |
It has been a while waiting for reviewing. I've push another branch(https://github.com/e-cloud/highcharts/tree/ref) to show how i generate the No offense, however, @TorsteinHonsi if your team don't want to accept the PR, please state it and close the PR, I will make another PR to DefinitelyTyped. |
Torstein is on vacation at the moment, but let's have a look. @cvasseng Is this something we can pull in? |
Thanks again for your contribution @e-cloud ! We are now continuing the work on our own TypeScript support, and will take this PR into account. |
sounds good. @TorsteinHonsi did you have a look over the ref branch? a BTW, could you reveal the plan of |
@e-cloud We are working internally since last year on the problem (with lower priority until recently). The goal beside declarations is to synchronize the online documentation and the declarations for TypeScript. Thanks to your contribution we might speed this up and hopefully have working declarations in the near future. We then will integrate it in our node package and also provide it to the definitelyTyped project to replace the current declarations there. |
this is because the highcharts team doesn't want to expost those interfaces yet.
@sophiebremer Could you point out the unresolved issues to see if I could solve them? |
@e-cloud No, I am sorry. These issues are about (project) synchronization. |
@sophiebremer what do you mean by synchronization? If you mean branch synchronization, I've rebase the branch to latest master two days ago. |
Closing this PR now, we're on track to complete TypeScript support. |
add these docs is to generate
highcharts.d.ts
at the next step.Seperating the changes into two PR is good for reviewing.
partly fix #4876
@TorsteinHonsi could you have a review over this.