* fixed typos in travis script and time tracker model

hicknhack-software · Feb 16, 2015 · 16c05c1 · 16c05c1
1 parent 85efc57
commit 16c05c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.travis-init.sh b/.travis-init.sh
@@ -58,18 +58,18 @@ run_tests() {
   # exit if tests fail
   set -e
 
-  cd $PATH_TO_REDMINE
+  cd "$PATH_TO_REDMINE"
   if [ "$USE_RSPEC" = "yes" ]
   then
     if [ "$VERBOSE" = "yes" ]; then
       export TRACE=--backtrace
     fi
-    script -e -c "bundle exec rspec plugins\"$PLUGIN"\spec" $TRACE
+    script -e -c "bundle exec rspec plugins\\$PLUGIN\spec $TRACE"
   else
     if [ "$VERBOSE" = "yes" ]; then
       export TRACE=--trace
     fi
-    script -e -c "bundle exec rake redmine:plugins:test NAME="$PLUGIN $TRACE
+    script -e -c "bundle exec rake redmine:plugins:test NAME=$PLUGIN $TRACE"
   fi
 
 }

diff --git a/app/models/time_tracker.rb b/app/models/time_tracker.rb
@@ -56,7 +56,7 @@ def to_json(options = {})
     if issue.nil?
       self.issue_id = self.issue_id_was if self.issue_id.present?
     else
-      raise StandardError, l(:tt_error_not_allowed_to_start_tracker_on_issue) if !help.permission_checker([:tt_book_time, :tt_edit_own_bookings, :tt_edit_bookings], issue.project)  || issue.closed
+      raise StandardError, l(:tt_error_not_allowed_to_start_tracker_on_issue) if !help.permission_checker([:tt_book_time, :tt_edit_own_bookings, :tt_edit_bookings], issue.project)  || issue.closed?
       self.project_id = issue.project_id unless issue.nil? || self.project_id == issue.project_id
     end
   end