Re-Start buildbot services based on a fact in start role, not in crea…

…te/install handler

master/create/handlers/main.yml

@@ -1,6 +1,4 @@
 ---
 - name: restart buildbot master
-  service:
-    name: buildbot
-    state: restarted
-
+  set_fact:
+    buildbot_master_restart: true

master/inplace-config/handlers/main.yml

@@ -1,5 +1,4 @@
 ---
-- name: reconfigure buildbot master
-  service:
-    name: buildbot
-    state: reloaded
+- name: restart buildbot master
+  set_fact:
+    buildbot_master_restart: true

master/install/handlers/main.yml

@@ -1,5 +1,4 @@
 ---
 - name: restart buildbot masters
-  service:
-    name: buildbot
-    state: restarted
+  set_fact:
+    buildbot_master_restart: true

master/start/tasks/main.yml

@@ -1,6 +1,12 @@
 ---
 
-- name: start buildbot master
+- name: enable buildbot master
   service:
     name: buildbot
-    state: started
+    enabled: yes
+
+- name: restart buildbot master
+  service:
+    name: buildbot
+    state: restarted
+  when: "{{ buildbot_master_restart | default(False) }}"

project/add/handlers/main.yml

@@ -1,5 +1,5 @@
 ---
 - name: reconfigure buildbot master
-  file:
-    path: "{{ buildbot_master_basedir }}/reconfig.txt"
-    state: touch
+  service:
+    name: "buildbot"
+    state: reloaded

winworker/create/tasks/store_passwd.yml

@@ -10,6 +10,7 @@
     src: "{{ buildbot_winworker_password_path }}"
   failed_when: no
   register: buildbot_read_password
+  tags: [always]
 
 - name: store_passwd | Generate Worker Password
   set_fact:

worker/create/handlers/main.yml

@@ -7,6 +7,5 @@
   delegate_to: '{{ buildbot_master_host }}'
 
 - name: restart buildbot worker
-  service:
-    name: buildbot-worker
-    state: restarted
+  set_fact:
+    buildbot_worker_restart: true

worker/start/tasks/main.yml

@@ -1,7 +1,13 @@
 ---
 - meta: flush_handlers
 
+- name: Restart Worker
+  service:
+    name: buildbot-worker
+    state: restarted
+  when: "{{ buildbot_worker_restart | default(False) }}"
+
 - name: Start Worker
   service:
     name: buildbot-worker
-    state: started
+    enabled: yes