This repository has been archived by the owner on May 12, 2020. It is now read-only.
Fix turbolinks issue which caused infinite scrollbar ond other UI loa… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AjayBarot I tested locally and I think animation is not working with this change 😢 |
Fix animation issue caused by turbolinks gem version changes.
2. disable turbolinks caching on each layout to solve back button issue.
|
@kenny-hibino : thanks for testing this changes into local. I have made some changes to cope up with back button issue and animation issue. Please have a look at this changes. https://github.com/kenny-hibino/stories/pull/45/files. and let me know your feedback after testing of this latest changes. Thank you pal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenny-hibino : Please review the changes. I tested overall application but still let me know If you inspect something unusual.
#35