HSEARCH-4542 .within() and .withinAny() for the range predicate #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
feat/HSEARCH-4542-within-and-withinAny-for-the-range-predicate
branch
from
f8e6ca4
to
c5ac711
Compare
yrodiere
reviewed
May 16, 2024
There was a problem hiding this comment.
Thanks; a few comments below.
FWIW, I think aligning on the syntax of the terms predicate is better than aligning on the syntax of the range aggregation.
I even wonder if we should change the syntax of the range aggregation... This .range(....).range(...) is quite awkward, too. Not in this PR for sure, though :)
...c/main/java/org/hibernate/search/engine/search/predicate/dsl/RangePredicateMatchingStep.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/hibernate/search/engine/search/predicate/dsl/RangePredicateMatchingStep.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/HSEARCH-4542-within-and-withinAny-for-the-range-predicate
branch
from
c5ac711
to
74660ec
Compare
|
yrodiere
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-4542