HSEARCH-5132 Do not directly rely on the Security Manager in EmbeddedThreadProvider #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
feat/HSEARCH-5132-Do-not-directly-rely-on-the-Security-Manager-in-EmbeddedThreadProvider
branch
2 times, most recently
from
ec27a8d
to
f6a11f3
Compare
|
@marko-bekhta Did you test this against the latest build of JDK 23? https://jdk.java.net/23/ If the tests pass on that version, I'd merge this PR. Even if they didn't remove the security manager yet; when they do, we'll know quite quickly whether this patch is enough or not. |
|
Started a JDK 23 build here https://ci.hibernate.org/job/hibernate-search/job/PR-4125/12/ I've looked at it on the previous build, and SM was still there so I just kept the PR open 🙈, let's see how the build goes 😃 |
marko-bekhta
force-pushed
the
feat/HSEARCH-5132-Do-not-directly-rely-on-the-Security-Manager-in-EmbeddedThreadProvider
branch
from
f6a11f3
to
fae53a6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-5132