hibernate.jdbc.time_zone support for Time #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
856-mysql-time
branch
2 times, most recently
from
106bf04
to
3edd38d
Compare
|
Well, OK, I agree that this is the most sane thing to do if we really have to support this setting, but it's not compatible with what core does, it's a different behavior. |
Good enough for me :-) |
We cannot apply a timezone to a time without a date, this probably the best we can do without throwing an exception.
When the test suite is fast enough, they might match. So `isAfter` doesn't work all the times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #856 ... sort of
This is what I would do and it seems consistent to what happens with ORM and MySQL (after a quick test).
I think OffsetTime is the one that's weird, because when we return the value it won't match the original Timezone.