schema export via reactive driver and fix for bug #113

[gavinking]

This supersedes #112.

[gavinking]

Alright, folks, so shall I merge this one?

[gavinking]

Silence indicates consent.

[DavideD]

No, it doesn't

[DavideD]

Maybe if you put a deadline. Anyway, it looks good, feel free to merge it

[gavinking]

Pushed manually.

[aguibert]

This has broken CI because it depends on core 5.5.0-SNAPSHOT. I'll create a new PR that does a clone+build of core 5.5.0-SNAPSHOT so we can still have CI coverage until the next version of core is released.

Aside from that, it looks like the user has to do 2 things to enable this:

1. register the no-op connection provider
2. Set the custom generation target

Can we make it so these steps happen automatically and the user gets the RX-based schema creation out of the box?

[DavideD]

This has broken CI because it depends on core 5.5.0-SNAPSHOT. I'll create a new PR that does a clone+build of core 5.5.0-SNAPSHOT so we can still have CI coverage until the next version of core is released.

The new ORM release will be ready shortly, before the end of the day. We decided to do an exception for this time and merge the PRs even if they refer to an unreleased version.
It's OK if you test it locally.

[gavinking]

Can we make it so these steps happen automatically

Yes, I was already working on that, and I just pushed the result.

[gavinking]

Yes, I was already working on that, and I just pushed the result.

Excuse me: I have pushed part 1 but not yet part 2.

[DavideD]

@gavinking Any idea about this error? https://github.com/hibernate/hibernate-reactive/pull/122/checks#step:4:151

[gavinking]

@gavinking Any idea about this error? https://github.com/hibernate/hibernate-reactive/pull/122/checks#step:4:151

I imagine you're referring to the test failure I fixed here.

[DavideD]

Yes, it's working now, thanks

…

On Mon, May 18, 2020 at 6:56 PM Gavin King ***@***.***> wrote: @gavinking <https://github.com/gavinking> Any idea about this error? https://github.com/hibernate/hibernate-reactive/pull/122/checks#step:4:151 I imagine you're referring to the test failure I fixed here <4e8b51a> . — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEIQ5K7RBPSAW4HVJKWHT3RSFZFVANCNFSM4NC7JVYQ> .