Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGM-571 Honor "hbm2ddl" setting to initialize and drop the schema #1111

Open
wants to merge 8 commits into
base: 5.3
Choose a base branch
from

Conversation

ggaborg
Copy link

@ggaborg ggaborg commented Jun 18, 2019

No description provided.

@DavideD
Copy link
Member

DavideD commented Jun 18, 2019

Hi, I have created a new pull request related to https://hibernate.atlassian.net/browse/OGM-571.
This is it #1111.
It does not solve the initial issue of lazy start of the mongodb datastore provider but maybe we can reach there after.

How come doesn't it solve the lazy initialization problem?

@ggaborg
Copy link
Author

ggaborg commented Jun 18, 2019

Because the start of the datastore provider has nothing to do with the creation of the schema. See MongoDBDatastoreProvider start method which extracts the database.

@DavideD
Copy link
Member

DavideD commented Jun 19, 2019

Sorry, I can't remember. Why did you use branch 5.3 instead of master?

@ggaborg
Copy link
Author

ggaborg commented Jun 19, 2019

Because I'm working with wildfly 13 with hibernate-core 5.3.1.Final

@ggaborg
Copy link
Author

ggaborg commented Jun 19, 2019

Also, removing the create database property is breaking backward compatibility so this change should impose the changing of the minor version at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants