Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files
with no errorsDocumented in docs/ as appropriateIn hunting down options to address hgrecco/pint-pandas#174 , the only solution i found so far to reliably work was to get rid of the
__array__
interface entirely, as a more extreme version of the discussion in #1128 .I was quite surprised to learn that nothing in pint directly depends on the interface, but i guess it would be too much of a breaking change. Nevertheless, I like the idea of pint not ever implictly stripping units.
More realistically this means a proper implementation of the
__array_ufunc__
alternative might solve at least the linked issue.I guess you all are exhausted by these discussion already, sorry that i am pbb missing all the basics.