Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switches to Smart Polls #4812

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iPaulPro
Copy link
Collaborator

What does this PR do?

Switches to using EASPollActionModule for polls.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

Copy link

height bot commented Apr 12, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web ❌ Failed (Inspect) Apr 12, 2024 10:46am

Copy link

vercel bot commented Apr 12, 2024

@iPaulPro is attempting to deploy a commit to the Hey Team on Vercel.

A member of the Team first needs to authorize it.

@iPaulPro
Copy link
Collaborator Author

This is very out of date because it was started well-over a month ago but I'm still waiting on the Open Action to be verified.

One thing missing from this PR, is to use optimistic status for the votes. I'm happy to add that, but didn't want to keep working on it if the action will not be verified in its current state.

@bigint
Copy link
Member

bigint commented Apr 12, 2024

Hey I think we can move RPC calls to FE rather than using API

@bigint
Copy link
Member

bigint commented Apr 12, 2024

Also I just invited to the repo so you can create branch here and contribute, I see lot of conflicts already 😅

@iPaulPro
Copy link
Collaborator Author

Just a couple updates: EAS isn't yet deployed on Amoy, and I'm still waiting on the poll module to be verified before I continue more work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants