feat: lens open frames standard #4802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@defispartan is attempting to deploy a commit to the Hey Team on Vercel. A member of the Team first needs to authorize it. |
bigint
reviewed
Apr 10, 2024
apps/api/src/routes/frame/post.ts
Outdated
|
|
||
| const { document } = parseHTML(data); | ||
|
|
||
| logger.info(`Portal button clicked by ${id} on ${postUrl}`); |
There was a problem hiding this comment.
Suggested change
| logger.info(`Portal button clicked by ${id} on ${postUrl}`); | |
| logger.info(`Open frame button clicked by ${id} on ${postUrl}`); |
| @@ -54,6 +55,8 @@ const Oembed: FC<OembedProps> = ({ publicationId, url }) => { | |||
| <Player og={og} /> | |||
| ) : og.nft ? ( | |||
| <Nft nft={og.nft} publicationId={publicationId} /> | |||
| ) : og.portal ? ( | |||
There was a problem hiding this comment.
Suggested change
| ) : og.portal ? ( | |
| ) : og.frame ? ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for embedding and interacting with Open Frames following the Lens specification
Related issues
Fixes # (issue)
Type of change
Explanation of the changes