Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwindcss 3.0 Class Support #177

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

tance77
Copy link
Contributor

@tance77 tance77 commented Dec 14, 2021

As always the order of the class sorting is taken from the documentation on the tailwindcss website from top to bottom.

At a glance I noticed that tailwindcss 3.0 removed classes such as border opacity and placeholder color. Some of the classes just have been renamed. See the upgrade guide for a full list of changes.

That being said these new updated classes wont have some of the old classes 2.0 has. Which would result of the classes being pushed to the end of the class list. I'm not sure how the author would like to proceed.

@tance77
Copy link
Contributor Author

tance77 commented Dec 14, 2021

I'm also not sure what the test it('should remove not delete duplicate classes when flag is set') is trying to test because the test description didn't make sense to me. If anyone could help with that test that would be greatly appreciated.

tance77 and others added 2 commits December 14, 2021 16:28
…ly doing. Adjusting same test to correspond to the first class now according to tailwindcss 3 docs
@tance77
Copy link
Contributor Author

tance77 commented Dec 15, 2021

it('should remove not delete duplicate classes when flag is set')

I think I figured out what was actually meant by this test and renamed the double negative to make the sentence more understandable

@HelloAlexPan
Copy link

This plugin does not seem to be maintained. Does anyone want to make a fork with this PR?

@tance77
Copy link
Contributor Author

tance77 commented Jan 26, 2022

This plugin does not seem to be maintained. Does anyone want to make a fork with this PR?

@HelloAlexPan It might be best to just switch to this. It just came out. https://tailwindcss.com/blog/automatic-class-sorting-with-prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants