Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker components #15

Merged
merged 4 commits into from
Apr 27, 2018
Merged

Add Docker components #15

merged 4 commits into from
Apr 27, 2018

Conversation

jasonwalsh
Copy link
Contributor

@brh55 Please review #14 before approving this PR.

Adds a Dockerfile for production and development environments.

Refer to the README for usage instructions. If the ACCESS_TOKEN and VERIFY_TOKEN environment variables are unassigned, Docker Compose throws an exception.

Usage of --frozen-lockfile derived from yarnpkg/yarn#4147.

jasonwalsh added 3 commits April 24, 2018 20:06
Signed-off-by: jasonwalsh <rightlag@gmail.com>
Signed-off-by: jasonwalsh <rightlag@gmail.com>
@jasonwalsh jasonwalsh requested a review from brh55 April 26, 2018 01:28
@@ -0,0 +1,8 @@
FROM node:alpine
ARG NODE_ENV=production
WORKDIR /srv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As intended, is it srv as in server or a meant to be src

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbal approval from @brh55

@jasonwalsh jasonwalsh merged commit 8e9f4db into master Apr 27, 2018
@jasonwalsh jasonwalsh deleted the docker branch April 27, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants