New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crontab backslash #4353
Open
Anuril
wants to merge
15
commits into
hestiacp:main
Choose a base branch
from
Anuril:fix-crontab-backslash
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix crontab backslash #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to edit in webinterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a fun one 😄
This fixes #4329 and some other issues with crontabs that were not yet found.
read
removed the backslash when reading the$USER_DATA/cron.conf
file because-r
wasn't used - sojson_decode
never received the string with\
.json_decode
inweb/list/cron/index.php
would have received it, it would've been buggy, as json_decode can't deal with single backslashes, so we have to manually escape the backslashes./web/edit/cron/index.php
I also noticed that the same thing happened when I wanted to use this crontab line:
/usr/bin/find /home/testuser/test/ -type f -exec echo "Files: "ls {} >> /home/testuser/test/log.log \;
And that issue was with double quotes.
EDIT: This also caused to not create the cron tab entries in the correct way, as
func/main.sh
also didn't use the-r
flag withread
.I also just noticed that there might be an issue when upgrading when suddenly the cronjobs in
$USER_DATA/cron.conf
are in a wrong format, which breaks the display of the list. I'll create a script to fix that.EDIT2: Fixed all the parsing issues with quotes and backslashes and all other characters by converting the command string to base64 and storing it that way.