Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick install namelessmc #4327

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Quick install namelessmc #4327

wants to merge 8 commits into from
+53 −0

Conversation

MCJUNIORLK
Copy link

Here is the first quick install app I made. Hope everything works out that way. (Hope I'm doing this right with the PR)

Anuril
Anuril approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Anuril Anuril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've tested the installation and it worked. I also tested installing on http and switching to https afterwards, so that's also fine.

@Anuril
Copy link
Contributor

Anuril commented Apr 4, 2024 •
edited

@MCJUNIORLK could you run prettier on the file ?
npx prettier --write web/src/app/WebApp/Installers/NamelessMC/NamelessMCSetup.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anuril Anuril Anuril approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MCJUNIORLK @Anuril