Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dns axfr implementation #3777

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

Anuril
Copy link
Contributor

@Anuril Anuril commented Jul 13, 2023

Basic DNS AXFR Implementation with the ability to create bind keys per cluster host.

@ghost ghost requested a review from jaapmarcus July 13, 2023 17:10
@jaapmarcus
Copy link
Member

Test server has some issues after the test where completed:

v-delete-dns-domain doesn't update named.conf.local when a domain gets removed

@Anuril
Copy link
Contributor Author

Anuril commented Jul 14, 2023

I've removed the reference to named.conf.local from the rebuild.sh & web config list. I will submit separate PR to move dns domain definition to named.conf.local.

@jaapmarcus
Copy link
Member

Please keep it in 1 PR it makes reviewing and testing a lot easier :)

Copy link
Member

@jaapmarcus jaapmarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a lot of work before it working

Currently working on it...

bin/v-create-dns-cluster-config Outdated Show resolved Hide resolved
bin/v-create-dns-cluster-config Outdated Show resolved Hide resolved
bin/v-create-dns-cluster-config Outdated Show resolved Hide resolved
bin/v-create-dns-cluster-config Outdated Show resolved Hide resolved
bin/v-create-dns-cluster-config Outdated Show resolved Hide resolved
@@ -99,6 +99,10 @@ else
sed -i "s/DNS_CLUSTER=.*/DNS_CLUSTER='yes'/g" $HESTIA/conf/hestia.conf
fi

# Create Cluster keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we want to enable it for every system on default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wouldn't be the case. Only if you enable DNS Cluster, which makes sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Ubuntu installer

web/edit/server/bind9/index.php Outdated Show resolved Hide resolved
bin/v-create-dns-cluster-config Outdated Show resolved Hide resolved
bin/v-add-dns-transfer-key Show resolved Hide resolved
@Anuril Anuril marked this pull request as draft September 5, 2023 12:18
@Anuril
Copy link
Contributor Author

Anuril commented Sep 5, 2023

I seem to have lost a bit of code in some merge... I need to add some more configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants