Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate(W-14169383): spaces: Upgrade trusted-ips:remove #2868

Merged
merged 2 commits into from May 7, 2024
Merged

migrate(W-14169383): spaces: Upgrade trusted-ips:remove #2868

merged 2 commits into from May 7, 2024

Conversation

justinwilaby
Copy link
Contributor

This PR moves trusted-ips:remove to the cli and migrates to TS

Test Instructions

  1. Checkout this branch and build
  2. run ./bin/run trusted-ips:remove --space YOUR_SPACE THE_IP_TO_REMOVE
  3. Verify the output is the same as the original

@justinwilaby justinwilaby requested a review from a team as a code owner May 3, 2024 18:04
@justinwilaby justinwilaby force-pushed the jw/spaces/migrate-trusted-ips-remove branch from 3d86c84 to 3f67f5f Compare May 3, 2024 20:05
@justinwilaby justinwilaby force-pushed the jw/spaces/migrate-trusted-ips-remove branch from 3f67f5f to d14fc6b Compare May 6, 2024 14:38
@sbosio sbosio self-requested a review May 7, 2024 14:01
sbosio
sbosio approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command works correctly. Small suggestion for the help text.

packages/cli/src/commands/spaces/trusted-ips/remove.ts Outdated Show resolved Hide resolved
@justinwilaby justinwilaby force-pushed the jw/spaces/migrate-trusted-ips-remove branch from d14fc6b to 9f759a0 Compare May 7, 2024 16:50
@justinwilaby justinwilaby enabled auto-merge (squash) May 7, 2024 16:51
@justinwilaby justinwilaby merged commit a2997fa into prerelease/9.0.0-alpha May 7, 2024
6 of 7 checks passed
@justinwilaby justinwilaby deleted the jw/spaces/migrate-trusted-ips-remove branch May 7, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbosio sbosio sbosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinwilaby @sbosio